scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 52 forks source link

Toppartitions sampling should return true cardinality instead of list size #148

Closed StarostaGit closed 3 years ago

StarostaGit commented 3 years ago

Right now, in the finishLocalSampling method of the ColumnFamilyStore we return the size of the list of returned partitions. Instead, we should be propagating the actual cardinality of the sampled set. It can be easily done by just reading the read_cardinality and write_cardinality properties of the scylla's REST API response.