search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 52 forks source link

CompactionManager: add the compaction id when available #160

Closed amnonh closed 3 years ago

amnonh commented 3 years ago

This patch adds the compaction id in getCompactions if it returns by the API, if it's not the current behaviour will be used and it will return none.

After this patch a call to nodetool compactionstats -H

Will return:

id compaction type keyspace table completed total unit progress c942bd30-7a62-11eb-84bc-576502584f9a COMPACTION keyspace1 standard1 1062 8576 keys 12.38% c9429620-7a62-11eb-8afb-576402584f9a COMPACTION keyspace1 standard1 972 8448 keys 11.51% Active compaction remaining time : 0h00m00s

Fixes scylladb/scylla#7927

Signed-off-by: Amnon Heiman amnon@scylladb.com

yakirgb commented 3 years ago

Why the values of completed and total with bytes and not human(-H) values like GiB/MiB/etc ?