search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 52 forks source link

storage_service: Fix getToppartitions to always return both reads and… #165

Closed StarostaGit closed 3 years ago

StarostaGit commented 3 years ago

… writes

In line with the previous API, the getToppartitions function returned results for one specified sampler (reads OR writes). This forced the user to call the function once for each sampler, which is suboptimal. This commit changes the signature so that results for both samplers are returned and the user can then pick whichever they need.

This is part of the fix for #243 and scylladb/scylla#8459

avikivity commented 3 years ago

I merged this, will let the tests verify that it still works with the old nodetool. Once it passes we can merge the new nodetool, ping me if I forget.

Can we make the new nodetool work with old jmx? I guess we can with try/catch.

StarostaGit commented 3 years ago

@avikivity by old jmx you mean before this commit or the one before generalizing toppartitions?