scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 52 forks source link

Scylla-JMX starting with wrong EnvironmentFile path by default on Ubuntu #174

Open tvdu29 opened 3 years ago

tvdu29 commented 3 years ago

Installation details

Scylla version (or git commit hash): Scylla version 4.4.3-0.20210609.bfafb8456 with build-id 0652dae198a719d3f82df05c921f00c785c2e449 Cluster size: 1 seed + 1 node OS (RHEL/CentOS/Ubuntu/AWS AMI): custom ami based on ami-03caf24deed650e2c (ubuntu 20.04)

Hardware details (for performance issues) Platform (physical/VM/cloud instance type/docker): AWS i3.large Hardware: cores=2vCPU memory=15.25Gib Disks: 475 GiB NVMe SSD

Installation specifics

Due to scylla-tools-core installing python2 as default python interpreter and breaking our ansible playbooks, we prefer to install scylla-server, scylla-jmx and scylla-kernel-conf independently to keep python3 as default.

Bug descripton

scylla-jmx seems get it's EnvironmentFile from the CentOs path (/etc/sysconfig/scylla-jmx) instead of the expected Ubuntu/Debian path (/etc/default/scylla), thus preventing proper configuration for remote nodetool connection.

Commands to run

*

$ sudo apt install scylla-server scylla-jmx scylla-kernel-conf
$ sudo scylla_setup --disks /dev/nvme0n1 --nic ens3 --setup-nic-and-disk --no-swap-setup --no-version-check --no-verify-package --no-node-exporter

Expected behavior

$ sudo cat /lib/systemd/system/scylla-jmx.service
...
[Service]
Type=simple
EnvironmentFile=/etc/default/scylla-jmx
...

Actual behavior

$ sudo cat /lib/systemd/system/scylla-jmx.service
...
[Service]
Type=simple
EnvironmentFile=/etc/sysconfig/scylla-jmx
...

Thank you for your work :)