search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 52 forks source link

Support `--load-and-stream` option from `nodetool refresh` #176

Closed jul-stas closed 2 years ago

jul-stas commented 2 years ago

This information is translated to {"load_and_stream", "true"} entry in the POST request to Scylla's HTTP API at storage_service/sstables/{keyspace} endpoint.

More about this feature: scylladb/scylla#7846 Mutually bonded change: scylladb/scylla-tools-java#273 Refs scylladb/scylla-tools-java#253.

nyh commented 2 years ago

I guess we can't commit documentation with the same PR because it's not in the same repository, but let's at least make sure we have an issue about adding such documentation, and a plan to do it quickly. Otherwise nobody will ever be able to use this new feature.\ I see this new feature is explained in https://groups.google.com/g/scylladb-dev/c/ZIYcEE76BYU?pli=1 but it's missing in https://docs.scylladb.com/operating-scylla/nodetool-commands/refresh/ (and in fact has a NOTE which begs to mention this new feature).

jul-stas commented 2 years ago

Is there a way to make sure this works as expected in an automatic way?

DTest may work - will check. Scylla logs the params of refresh queries, so it can be our hook.

jul-stas commented 2 years ago

@scylladb/scylla-jmx-maint ping (dtest is already merged and I promise I'll remember about the docs)