scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 51 forks source link

metrics: sstables_per_read_histogram returns number of sstables reads #199

Closed Deexie closed 1 year ago

Deexie commented 1 year ago

EstimatedHistogram, which is responsible for sstablesPerRead column in SSTablesPerReadHistogram table histogram, returns values indicating the number of sstables reads instead of the number of sstables.

mykaul commented 1 year ago

We don't have the 'backport candidate' label here - unsure what the process is later on, since we do wish to have this fix in earlier releases as well (do we update the submodule?). @DoronArazii - need to follow up once this is merged.

DoronArazii commented 1 year ago

@DoronArazii - need to follow up once this is merged.

It's in master --> https://github.com/scylladb/scylladb/commit/50ee4033a92e395e70c08e64d60667bb2681fd2b

denesb commented 1 year ago

@DoronArazii - need to follow up once this is merged.

It's in master --> scylladb/scylladb@50ee403

It is actually scylladb/scylladb@f82287a9afbdaeb87138a0918f05f4c52e9b5966.