search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
29 stars 53 forks source link

dist/debian: drop dependencies on jdk-8 #209

Closed tchaikov closed 1 year ago

tchaikov commented 1 year ago

this change mirrors https://github.com/scylladb/scylla-jmx/commit/f89670dfd80ed04860e1098f0fc6ef114793f31b, since the oldest supported debian and its derivative are debian 10 and ubuntu 18.04, both of which ship openjdk-11-jre-headless. and oracle provides oracle-java11-set-default for them. so it's safe to drop the optional dependencies on openjdk-8 and orcale-java8.

this would ensure that the scylla-jmx deb package's access to jdk-11.

Fixes https://github.com/scylladb/scylla-jmx/issues/194

tchaikov commented 1 year ago

@nyh and @denesb hi Nadav and Botond, could you help review this change?

avikivity commented 1 year ago

Even centos 7 has java 11, so how about we align the dependencies everywhere?

tchaikov commented 1 year ago

@avikivity we already updated the rpm side in https://github.com/scylladb/scylla-jmx/commit/f89670dfd80ed04860e1098f0fc6ef114793f31b . This change is the missing puzzle.

avikivity commented 1 year ago

Ok. But we have to merge the other change first, otherwise an upgrade to a version that only contains this patch will break.

tchaikov commented 1 year ago

Ok. But we have to merge the other change first, otherwise an upgrade to a version that only contains this patch will break.

are you referring #208 ?

avikivity commented 1 year ago

yes, I see it's merged now.

avikivity commented 1 year ago

The second patch was broken, I dropped it.

19:43:47  dpkg-buildpackage: error: syntax error in debian/control at line 12: duplicate field Depends found
tchaikov commented 1 year ago

The second patch was broken, I dropped it.

19:43:47  dpkg-buildpackage: error: syntax error in debian/control at line 12: duplicate field Depends found

sorry. fixed and created as #210