search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 51 forks source link

install.sh: bail out if jdk is not available #211

Closed tchaikov closed 1 year ago

tchaikov commented 1 year ago

in 96adf0ef51ad49b6abb98867f73cf69705f5f3e3, we started using select-java for selecting the JRE for running scylla-jmx, but it failed to reference select-java with the correct path. as in the unified reloc package, select-java is located at scylla-jmx/select-java, install.sh is located under the same directory. so we should use ./select-java here.

also, we should error out if the expected JDK is not found. this is the behavior before 96adf0ef51ad49b6abb98867f73cf69705f5f3e3

tchaikov commented 1 year ago

@fruch and @temichus could you help review this change?

avikivity commented 1 year ago

@fruch @mykaul we should think about dropping support for jdk 8.

fruch commented 1 year ago

@fruch @mykaul we should think about dropping support for jdk 8.

I think it would be fine, the only place we still need is for running cassandra 3.11 in testing.

As for customers, we probably need to advertise it in advance that 5.3 onward would support 11 only (since we are not testing with newer versions)