search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
29 stars 53 forks source link

StorageService: Normalize endpoint inetaddress strings to java form #229

Closed elcallio closed 10 months ago

elcallio commented 10 months ago

Fixes #228

Endpoint strings in StorageService does not follow Java formatting for IPv6 nodes. This causes nodetool to break when mixing API:s returning actual IP addresses with info mapped by string. Example is nodetool status.

Refs scylladb/scylladb#16039

While this is really broken nodetool code, the problem is probably easier to fix here, in Scylla-JMX, as a stopgap until we can fully replace nodetool.

avikivity commented 10 months ago

@denesb please check native nodetool compatibility too

denesb commented 10 months ago

@denesb please check native nodetool compatibility too

nodetool status is not implemented yet.

avikivity commented 10 months ago

ok, but please review this, since you're now our nodetool expert

denesb commented 10 months ago

Submodule update PR: https://github.com/scylladb/scylladb/pull/16146