search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
28 stars 51 forks source link

dist/debian: do not use substvar of ${shlib:Depends} #232

Closed tchaikov closed 3 months ago

tchaikov commented 6 months ago

this subvar is exposed by dpkg-shlibdeps, which checks executables for their shared library dependencies, and expose them as shlib:Depends substitution variable.

but in the case of jmx, in place of executables, we package scylla-jmx-1.0.jar, which is a java jar archive. so we don't need to add dependencies for it.

also, we don't run dpkg-shlibdeps at all. that's why dpkg-gencontrol complains like:

dpkg-gencontrol: warning: Depends field of package scylla-jmx:
substitution variable ${shlibs:Depends} used, but is not defined

so, let's just drop this subst var.

tchaikov commented 6 months ago

@syuu1228 hi Takuya, could you please help review this change? it should help to silence the warning like

11:19:35  dpkg-gencontrol: warning: Depends field of package scylla-jmx: substitution variable ${shlibs:Depends} used, but is not defined

see https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/5564/console

tchaikov commented 5 months ago

@syuu1228 ping?

tchaikov commented 5 months ago

@syuu1228 ping?

tchaikov commented 4 months ago

@syuu1228 ping?

tchaikov commented 3 months ago

@syuu1228 ping?

denesb commented 3 months ago

@tchaikov this repo has its hours counted: it is on the way out. I don't think there is any point trying to improve it further.

tchaikov commented 3 months ago

@denesb hi Botond, thank you for your insights. partially agreed. because it's still used by old branches. and it takes human cycles to parse the warnings -- i check every single warning in the build logging messages actually when the build fails. so it is still relevant to the supported branches, i think.

denesb commented 3 months ago

Thanks for the explanation @tchaikov, good point.