search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
29 stars 54 forks source link

Allow systemd to run scylla-jmx with params from /etc/defaults/ #48

Closed fdv closed 7 years ago

fdv commented 7 years ago

Using systemd to run scylla-jmx won't load params from /etc/defaults/scylla-jmx because it expects params to be sent using the command line.

This patch enhances the sysconfig file by adding the available options (commented) and passes the right options to systemd ExecStart when defined. That way scylla-jmx is ran with the params defined into /etc/defaults/scylla-jmx.

Maybe not the most elegant way to do it, but 1/ it works 2/ I didn't find a better solution to fix that problem.

dorlaor commented 7 years ago

@syuu1228 @amnonh pls review. @fdv, thanks for the contribution! We usually use patches, not pulls but we can make it a one off, we do ask for a CLA - http://www.scylladb.com/open-source/

fdv commented 7 years ago

I've sent the CLA, I can also send a patch the usual way if you prefer.

And this PR incidentaly fixes issues #44

penberg commented 7 years ago

The PR is merged as the following commit:

https://github.com/scylladb/scylla-jmx/commit/e80a5e3cb319fc80c669d6d75f5abeb0d781758b