search

scylladb / scylla-machine-image

Apache License 2.0
18 stars 25 forks source link

scylla_cloud_io_setup: add preset configuration for all supported instance types on EC2 #473

Closed syuu1228 closed 10 months ago

syuu1228 commented 10 months ago

Since we merged https://github.com/scylladb/scylladb/commit/817f34d1a94a1daa1e8591c93a047081d51f5628, we are missing preset configuration for c5d, m5d, m5ad, r5d, z1d. On such instance, our AMI causes error during startup (see scylladb/scylladb#9660). To fix the problem, we need to add preset configuration for these instance types.

syuu1228 commented 10 months ago

This patch copied from https://github.com/scylladb/scylladb/pull/9694, since we moved all cloud related code to this repository.

mykaul commented 10 months ago

@syuu1228 - at some point, we should move this code into a Python dictionary, no?

benipeled commented 10 months ago

@syuu1228 please make sure to verify every change in advanced In this case, use the machine-image releng-testing pipeline (or byo)