search

scylladb / scylla-machine-image

Apache License 2.0
19 stars 26 forks source link

Add missing i4g.4xlarge instnace type #476

Closed yaronkaikov closed 1 year ago

yaronkaikov commented 1 year ago

Adding pre-configure io_setup values Also since i4g doesn't support enhanced networking adding it to use ENA

Annamikhlin commented 1 year ago

Please check if you need to remove the i4g.large type, if it not should be supported https://github.com/scylladb/scylla-machine-image/blob/a5c370764b976059a089e888b849115504a1c8ee/common/scylla_cloud_io_setup#L296-L300

yaronkaikov commented 1 year ago

Please check if you need to remove the i4g.large type, if it not should be supported

https://github.com/scylladb/scylla-machine-image/blob/a5c370764b976059a089e888b849115504a1c8ee/common/scylla_cloud_io_setup#L296-L300

We should support it as well. so keeping it

Annamikhlin commented 1 year ago

Please check if you need to remove the i4g.large type, if it not should be supported https://github.com/scylladb/scylla-machine-image/blob/a5c370764b976059a089e888b849115504a1c8ee/common/scylla_cloud_io_setup#L296-L300

We should support it as well. so keeping it

So we are supporting it but not testing it?

Annamikhlin commented 1 year ago

Please check if you need to remove the i4g.large type, if it not should be supported https://github.com/scylladb/scylla-machine-image/blob/a5c370764b976059a089e888b849115504a1c8ee/common/scylla_cloud_io_setup#L296-L300

We should support it as well. so keeping it

So we are supporting it but not testing it?

Ok, I see your answer in https://github.com/scylladb/scylla-pkg/pull/3556#discussion_r1309918566 :)

yaronkaikov commented 1 year ago

Verified with https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/artifacts/job/artifacts-ami-arm-test/71/