search

scylladb / scylla-machine-image

Apache License 2.0
19 stars 26 forks source link

Refactor aws_io_setup class - specifically, the IO values per instance #544

Open mykaul opened 2 weeks ago

mykaul commented 2 weeks ago

My eyes hurt from seeing so many `elif'. See https://github.com/scylladb/scylla-machine-image/blob/ad01b2a28092b0488f5de443da51a51285c98a14/common/scylla_cloud_io_setup#L41 We should store this in a dictionary, JSON or whatnot. Single location preferably.

mykaul commented 2 weeks ago

Part of this (I should open a separate issue for it!) is that we need to validate the numbers are still real. Ref https://github.com/scylladb/scylla-enterprise/issues/4713#issuecomment-2367619463 We do have a job that is testing a wide range of instances, it should probably compare the results and the hard-coded values (CC @roydahan )

roydahan commented 1 week ago

I created a separate issue for the above comment in qa-tasks.

roydahan commented 1 week ago

My eyes hurt from seeing so many `elif'. See

https://github.com/scylladb/scylla-machine-image/blob/ad01b2a28092b0488f5de443da51a51285c98a14/common/scylla_cloud_io_setup#L41

We should store this in a dictionary, JSON or whatnot. Single location preferably.

Hurt is understatement. @yaronkaikov a dictionary is the simplest and quickest solution.