search

scylladb / scylla-manager

The Scylla Manager
https://manager.docs.scylladb.com/stable/
Other
51 stars 33 forks source link

Close client and session #3777

Closed Michal-Leszczynski closed 6 months ago

Michal-Leszczynski commented 6 months ago

Fixes #3769

karol-kokoszka commented 6 months ago

@Michal-Leszczynski It's failing the repair. I need to merge closing client on session creation. Rest will be updated in next release.

Michal-Leszczynski commented 6 months ago

@karol-kokoszka I'm trying to understand why that's the case. Maybe it discovered some unrelated bug. Failing repair test pauses ongoing repair 4 times and it fails with fifth repair returning session closed error:

2024-03-29T12:27:53.5782633Z --- When: run second repair with context cancel
2024-03-29T12:27:54.0160885Z --- When: run third repair with context cancel
2024-03-29T12:27:54.4337332Z --- When: run fourth repair with context cancel
2024-03-29T12:27:54.8595888Z --- When: run fifth repair till it finishes
2024-03-29T12:27:55.2806464Z     service_repair_integration_test.go:1074: Repair failed: get cluster views: session has been closed

I'm wondering if we actually somehow cache those sessions? What could be the reason for that? But that's true that it can't be included in the 3.2.7 release without some investigation.

Michal-Leszczynski commented 6 months ago

@karol-kokoszka It looks like the cause of the error was the fact that repair tests cached CQL session.

karol-kokoszka commented 6 months ago

please resolve the conflicts

Michal-Leszczynski commented 6 months ago

@karol-kokoszka conflicts are resolved!