fix(restore): post-restore repair to use max intensity and parallel

scylladb / scylla-manager

The Scylla Manager

https://manager.docs.scylladb.com/stable/

Other

48 stars 33 forks source link

fix(restore): post-restore repair to use max intensity and parallel #3832

Closed karol-kokoszka closed 1 month ago

karol-kokoszka commented 2 months ago

Fixes #3823 Fixes #3542

Please make sure that:

Code is split to commits that address a single change
Commit messages are informative
Commit titles have module prefix
Commit titles have issue nr. suffix

Michal-Leszczynski commented 1 month ago

The reason for repair test failure: #3834.

Michal-Leszczynski commented 1 month ago

I'm fine with this change and I actually created identical PR in the past that was rejected because this comment. Did we validate that sctool repair control works on restore repair as intended? Or maybe this change should be introduced only alongside #3666?

karol-kokoszka commented 1 month ago

Right, would be good to have the repair control available for this post-restore. Let's discuss on grooming.

karol-kokoszka commented 1 month ago

@Michal-Leszczynski did you have a chance to check if repair control works when the post-restore repair is on-going ?

karol-kokoszka commented 1 month ago

OK, it is updating the port-restore repair.