scylladb / scylla-manager

The Scylla Manager
https://manager.docs.scylladb.com/stable/
Other
48 stars 33 forks source link

healthcheck: runner to return error #3880

Closed karol-kokoszka closed 2 weeks ago

karol-kokoszka commented 3 weeks ago

Return error from healtcheck runner


Please make sure that:

Michal-Leszczynski commented 2 weeks ago

I understand that this change is fixing the logging from run.Parallel. While we are at it, could we also change:

_ = parallel.Run(len(addresses), parallel.NoLimit, f, func(i int, err error) { // nolint: errcheck
        r.logger.Error(ctx, "Parallel hosts check failed", "", addresses[i], "error", err)
    })

so that we don't include an empty string in logging? It should be something like "host" instead.

karol-kokoszka commented 2 weeks ago

updated