scylladb / scylla-manager

The Scylla Manager
https://manager.docs.scylladb.com/stable/
Other
51 stars 33 forks source link

[SCT] Add an option to reuse existing backup for restore benchmark test #3950

Closed mikliapko closed 1 week ago

mikliapko commented 1 month ago

The problem There is a great interest to improve Manager restore operation performance.

For this purpose we need to have stable SCT job for benchmarking.

The bottleneck of the test we have now is:

Both these operations are not significant for restore benchmarking purposes since might be eliminated in the test itself.

The solution The possible solution to speed up the testing process might be a restore from precreated backups for different datasets (500GB, 1TB, 2TB, 5TB).

To achieve it, I suggest to add extra parameter to SCT job to whether reuse existing backup or write and backup the data from scratch.

mikliapko commented 1 month ago

@fruch Is it safe to use s3:manager-backup-tests-us-east-1 bucket for such backup storing purpose? Do we have any retention policies for this bucket?

fruch commented 1 month ago

@fruch Is it safe to use s3:manager-backup-tests-us-east-1 bucket for such backup storing purpose? Do we have any retention policies for this bucket?

one should one and check, I remember it was setup to clear things after a week. but that was long time ago, before restore was available, and @ShlomiBalalis was keeping backup for longer durations. I don't remember where those are kept, and how retention works now