scylladb / scylla-manager

The Scylla Manager
https://manager.docs.scylladb.com/stable/
Other
51 stars 33 forks source link

Manager should not manage more than 5 OSS clusters #4018

Open mykaul opened 1 week ago

mykaul commented 1 week ago

Based on their versions, Manager should not allow to manage more than 5 open source clusters. It should emit a nice error message explaining the limitation when someone tries to add the 6th.

tzach commented 1 week ago

ScyllaDB Manager is free to use for all customers up to 5 nodes for clusters built with ScyllaDB Open Source. Customers using ScyllaDB Enterprise can connect an unlimited number of nodes with clusters deployed across multiple datacenters. https://www.scylladb.com/download/open-source/scylla-manager/

Michal-Leszczynski commented 1 week ago

This is about informing good-willed users that didn't remember about this limitation? Since SM is open source, they can always fork the repo and remove this limitation from the code.

Also, would SM verify that given cluster is Enterprise based only on the Scylla version? If I understand correctly, images with Scylla Enterprise are also available to anyone, so not only the customers.

karol-kokoszka commented 15 hours ago

As per @Michal-Leszczynski, let's check if the cluster consists of Scylla Enterprise servers or of OSS ones. If the cluster is the OSS one, do the check on:

Michal-Leszczynski commented 10 hours ago

@tzach is it possible that some paying customer is using open source Scylla instead of the enterprise one? If that's possible, then we can't return the error on failed check. We can just log it or print it in the sctool output.

tzach commented 6 hours ago

@tzach is it possible that some paying customer is using open source Scylla instead of the enterprise one?

It is possible, but not common.