Open wtibbitts opened 2 years ago
can you try disable preserve timestamps if it fixes your issue? @jwsomis ?
I just want to see if ordering for preserve timestamp and column rewrite don't conflict
That did seem to resolve it, but that also seems to avoid this particular collision all together as it doesn't seem to generate the duplicate tokn_ttl like it did before. Which leads me to another question, we were using the renames to handle this collision, but would disabling preserveTimestamps be just as effective?
so this is not really a regression but we have a bug when both rename and preserve timestamp is set
both affect schema generation in code and migrator needs to do rename for ttl tokens too
The only reason I consider it a regression is that it did work for me a couple weeks ago to have both preserveTimestamps and a rename, but I have not checked out an older version to re confirm that the same config that is broken now worked prior it is just from memory that nothing was changed.
Renames was working for me when I pulled and built from about 10 days ago, but has stopped working since then. Schema after renames still shows correctly, but the error is the same as when I had the naming conflict prior to renames (see
tokn_ttl type string
of original schema, conflicted with generatedtokn_ttl of type integer
)Config:
Run logs: