AWS AMIs: we should share them exactly like scylla images

scylladb / scylla-monitoring

Simple monitoring of Scylla with Grafana

https://scylladb.github.io/scylla-monitoring/

Apache License 2.0

229 stars 139 forks source link

AWS AMIs: we should share them exactly like scylla images #2375

Open fruch opened 1 month ago

fruch commented 1 month ago

Images should be shared exactly like scylla images see: https://github.com/scylladb/scylla-machine-image/commit/f6400eccef465a932daee593cbd2c1d2df130970

for us to be able to consume them

Annamikhlin commented 3 weeks ago

I see that the scylladb-monitor AMIs shared via organization path

arn:aws:organizations::978072043225:organization/o-o561yy1rs6
arn:aws:organizations::978072043225:ou/o-o561yy1rs6/ou-nfe9-40dtbmzs
arn:aws:organizations::978072043225:ou/o-o561yy1rs6/ou-nfe9-pcouwaqn

first one main RND account, not sure what are the others.

and addition, is also shared with 2 account IDs:

400694452550
871738363549

example from scylladb-monitor-4-8-0-2024-07-11t06-07-22z AMI

In addition, the snapshot shared as well with 2 accounts:

AWS account ID
400694452550
871738363549

@fruch @amnonh - are all of these needed?

Annamikhlin commented 3 weeks ago

Following the work done with @karol-kokoszka, the account of scylla cloud LAB (734708892259) was added as well to snapshot shared. The full snapshot shared account list for now is:

AWS account ID
400694452550
797456418907
871738363549

It was confirmed by @karol-kokoszka that it worked for him.

Need to check if other accounts are still relevant

fruch commented 3 weeks ago

Following the work done with @karol-kokoszka, the account of scylla cloud LAB (734708892259) was added as well to snapshot shared. The full snapshot shared account list for now is:
AWS account ID
400694452550
797456418907
871738363549
It was confirmed by @karol-kokoszka that it worked for him.

Need to check if other accounts are still relevant

797456418907 is needed by SCT

mykaul commented 2 weeks ago

I'm not sure why we are sharing account IDs publically. They are not secret, but there's no reason to share them broadly.

karol-kokoszka commented 2 weeks ago

I think it’s enough to share it with LAB. We are making the copy of it later on LAB, sharing with stage and prod + copy to supported regions.

W dniu pon., 26.08.2024 o 20:17 Yaniv Kaul @.***> napisał(a):

I'm not sure why we are sharing account IDs publically. They are not secret, but there's no reason to share them broadly.

— Reply to this email directly, view it on GitHub https://github.com/scylladb/scylla-monitoring/issues/2375#issuecomment-2310793497, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL77MOI7RDSI5EL2QIPHK63ZTNWLVAVCNFSM6AAAAABMENKVRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQG44TGNBZG4 . You are receiving this because you were mentioned.Message ID: @.***>