search

scylladb / scylla-monitoring

Simple monitoring of Scylla with Grafana
https://scylladb.github.io/scylla-monitoring/
Apache License 2.0
232 stars 140 forks source link

scylla-detailed: compression panels, remove raw and make the title clearer #2395

Closed amnonh closed 1 week ago

amnonh commented 2 weeks ago

After the change, add ratio, and show only sent information image

Fixes #2392

amnonh commented 1 week ago

@michoecho following comment from @mykaul do we need both send and receive? It should be the same, so maybe we can show just one of them

michoecho commented 1 week ago

@michoecho following comment from @mykaul do we need both send and receive? It should be the same, so maybe we can show just one of them

The contents of the dashboard should be dictated by its purpose.

If the purpose is to show the compression ratio, or the overall throughput of RPC network traffic in the cluster, then showing "send" alone is good enough, because "receive" should — in total — have the same information. If the purpose is to be yet another data point for debugging performance issues, then send and receive are different, and should be both displayed.

mykaul commented 1 week ago

@michoecho following comment from @mykaul do we need both send and receive? It should be the same, so maybe we can show just one of them

The contents of the dashboard should be dictated by its purpose.

If the purpose is to show the compression ratio, or the overall throughput of RPC network traffic in the cluster, then showing "send" alone is good enough, because "receive" should — in total — have the same information. If the purpose is to be yet another data point for debugging performance issues, then send and receive are different, and should be both displayed.

For debugging we have the Prometheus interface, if we need to query both, IMHO.