Prometheus: Enable --web.enable-lifecycle by default

scylladb / scylla-monitoring

Simple monitoring of Scylla with Grafana

https://scylladb.github.io/scylla-monitoring/

Apache License 2.0

240 stars 142 forks source link

Prometheus: Enable --web.enable-lifecycle by default #417

Closed tzach closed 5 years ago

tzach commented 6 years ago

Lifecycle is useful to refresh config file on runtime In Prometheus 2.0 it is disable by default

amnonh commented 5 years ago

I don't think it's needed, promethues by default check if a file change. If you manage to bypass the container limitations, it would reload automatically with no need to call the API.

amnonh commented 5 years ago

@tzach please comment or close