scylladb / scylla-monitoring

Simple monitoring of Scylla with Grafana
https://scylladb.github.io/scylla-monitoring/
Apache License 2.0
239 stars 142 forks source link

Non Token Aware queries for counters #804

Open dahankzter opened 4 years ago

dahankzter commented 4 years ago

The Non Token Aware Queries graph doesn't seem to be accurate for counters. We have tested both the Go driver (https://github.com/scylladb/gocql/issues/32) and cassandra-stress and both of them shows a large number in this graph but none when switching to integer fields or text for example.

cassandra-stress run:

cassandra-stress counter_write no-warmup cl=QUORUM duration=30s -schema 'replication(factor=2) compaction(strategy=SizeTieredCompactionStrategy)' keyspace=counter -port jmx=7100 -mode cql3 native -rate threads=1

This is both on multi node setups and even single node clusters.

dahankzter commented 4 years ago

Screenshot from 2020-01-29 14-02-55 Screenshot from 2020-01-29 14-02-36

jul-stas commented 4 years ago

For future readers: it also might be worth noting that:

slivne commented 4 years ago

@amnonh ping ...

amnonh commented 4 years ago

@slivne you volunteered to have a look, let me know if you can't

gcarmin commented 4 years ago

@slivne @amnonh any update on this one?

gcarmin commented 4 years ago

@slivne @amnonh any update on this one?

slivne commented 4 years ago

this is the source of the issue: https://github.com/scylladb/scylla/issues/4337

I'll need to followup with gleb on this.

amnonh commented 4 years ago

@slivne any updates?

amnonh commented 4 years ago

@slivne ping

amnonh commented 4 years ago

@slivne please comment to know if we want to close this

gcarmin commented 3 years ago

@vladzcloudius FYI

slivne commented 3 years ago

The counter today indeed is not updated and token-awareness in the dashboards is incorrectly displayed

we will either

mrsinham commented 3 years ago

@amnonh Vlad told me to ping you on this issue!

amnonh commented 3 years ago

@slivne we need to link to a scylla issue

slivne commented 3 years ago

@jul-stas is looking at this https://github.com/scylladb/scylla/issues/4337

@amnonh you can also try and have a temp solution by removing counter updates for now - it will not be as good but will be a stop the gap till scylla releases will havea solution

amnonh commented 3 years ago

There is a workaround in Scylla Monitoring 3.6.2

gcarmin commented 3 years ago

@amnonh what is the workaround?

amnonh commented 3 years ago

when counters or LWT in use, it will not show non-token aware