CRDs are missing embedded metadata

tnozicka commented 1 year ago

Describe the bug Generated CRDs are missing embedded metadata. One example is

$ kubectl explain scylladbmonitoring.spec.components.prometheus.storage.volumeClaimTemplate.metadata
KIND:     ScyllaDBMonitoring
VERSION:  scylla.scylladb.com/v1alpha1

DESCRIPTION:
     May contain labels and annotations that will be copied into the PVC when
     creating it. No other fields are allowed and will be rejected during
     validation.

     May contain labels and annotations that will be copied into the PVC when
     creating it. No other fields are allowed and will be rejected during
     validation.
$

another is this strict validation failure with kube v1.27.1 in or e2e suite

  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc00041e820>: 
      ScyllaDBMonitoring in version "v1alpha1" cannot be handled as a ScyllaDBMonitoring: strict decoding error: unknown field "spec.components.prometheus.storage.volumeClaimTemplate.metadata.creationTimestamp"
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "ScyllaDBMonitoring in version \"v1alpha1\" cannot be handled as a ScyllaDBMonitoring: strict decoding error: unknown field \"spec.components.prometheus.storage.volumeClaimTemplate.metadata.creationTimestamp\"",
              Reason: "BadRequest",
              Details: nil,
              Code: 400,
          },
      }
  occurred
  In [It] at: github.com/scylladb/scylla-operator/test/e2e/set/scylladbmonitoring/scylladbmonitoring.go:69 @ 05/15/23 08:30:48.073

tnozicka commented 1 year ago

moved creation timestamp into #1251, as the solution will be different

scylla-operator-bot[bot] commented 1 month ago

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out

/lifecycle stale

tnozicka commented 1 month ago

/remove-lifecycle stale /triage accepted

scylladb / scylla-operator

CRDs are missing embedded metadata #1249