search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Missing `mapstructure` tag in BackupTaskStatus #1852

Closed rzetelskik closed 3 months ago

rzetelskik commented 3 months ago

What happened?

Inlined BackupTaskSpec in BackupTaskStatus is missing a mapstructure tag https://github.com/scylladb/scylla-operator/blob/1520cf77e2bd089ad3497264dbd86196a4586f29/pkg/api/scylla/v1/types_cluster.go#L600 It causes the conversion between our and managerclient APIs to miss the task properties entirely.

/kind bug

What did you expect to happen?

It should have the mapstructure:",squash" tag.

How can we reproduce it (as minimally and precisely as possible)?

n/a

Scylla Operator version

master

Kubernetes platform name and version

n/a

Please attach the must-gather archive.

n/a

Anything else we need to know?

One of the many issues behind https://github.com/scylladb/scylla-operator/issues/1827 and a prerequisite for https://github.com/scylladb/scylla-operator/issues/1752.

rzetelskik commented 3 months ago

/priority critical-urgent since this is a prerequisite for https://github.com/scylladb/scylla-operator/issues/1752