scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Deprecate interval in manager task schedule spec #1853

Closed rzetelskik closed 2 months ago

rzetelskik commented 3 months ago

Description of your changes: This PR deprecates the interval field in manager task schedule spec in favour of cron.

Which issue is resolved by this Pull Request: Resolves https://github.com/scylladb/scylla-operator/issues/1796

/kind feature /priority important-longterm /hold for https://github.com/scylladb/scylla-operator/pull/1851

rzetelskik commented 2 months ago

known manager flake /test images /retest

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rzetelskik commented 2 months ago

thanks Tomas /test images e2e-gke-parallel

rzetelskik commented 2 months ago

/hold cancel

rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest ci/prow/e2e-gke-parallel-clusterip 9072ede link unknown /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

known manager flake /retest

rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

same thing /retest

rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fcfb09120c2d595dbf891d31a5c2c74a54f link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 9072ededeac37ec30f66259af229a6d3759b34cf link true /test e2e-gke-parallel-clusterip

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

and again /retest

rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

again /retest

rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

/shrug /retest

scylla-operator-bot[bot] commented 2 months ago

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fcfb09120c2d595dbf891d31a5c2c74a54f link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rzetelskik commented 2 months ago

/retest