search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Collect related objects for ScyllaClusters and ScyllaDBMonitorings in must-gather #1855

Closed tnozicka closed 2 months ago

tnozicka commented 3 months ago

Description of your changes: This PR adds support for collecting related resources for ScyllaClusters and ScyllaDBMonitorings. Because not all resources are connected through ownerReferences we dump the same namespace and don't filter the objects. Some examples of where ownerRefs wouldn't works are Services, Endpoints or other objects that don't have a direct relationship but affect say firewall rules (like NetworkPolicy). In the end, dumping all the objects in the same namespace seems like the best path.

Which issue is resolved by this Pull Request: Resolves #1568

tnozicka commented 3 months ago

https://github.com/scylladb/scylla-operator/issues/1694#issuecomment-2034003561 /retest

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 2 months ago

https://github.com/scylladb/scylla-operator/issues/1900 (repair task wasn't deleted) /retest

tnozicka commented 2 months ago

master moved / images issue /test images

tnozicka commented 2 months ago

/retest

tnozicka commented 2 months ago

same manager flake /retest

scylla-operator-bot[bot] commented 2 months ago

@tnozicka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 00d0a56c5f5dd6e9c2c98174ba16efaef22c7e81 link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tnozicka commented 2 months ago

and once again https://github.com/scylladb/scylla-operator/issues/1694#issuecomment-2066302006 /retest