search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Update Go version to 1.22 #1861

Closed rzetelskik closed 3 months ago

rzetelskik commented 3 months ago

Description of your changes: This PR updates the Go version to 1.22 and accommodates the loopvar fix and ranging over integers introduced in this release.

Which issue is resolved by this Pull Request: Resolves https://github.com/scylladb/scylla-operator/issues/1860

/kind feature /priority important-soon

scylla-operator-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rzetelskik commented 3 months ago

https://github.com/scylladb/scylla-operator/issues/1478#issuecomment-2022437025 /test images /retest

tnozicka commented 3 months ago

/hold you need to bump the CI as well see https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1861/pull-scylla-operator-master-unit/1772754204822081536#1:build-log.txt%3A1

tnozicka commented 3 months ago

xref for images fix https://github.com/scylladb/scylla-operator-images/pull/44

rzetelskik commented 3 months ago

/test unit

rzetelskik commented 3 months ago

/test all

rzetelskik commented 3 months ago

/hold cancel

rzetelskik commented 3 months ago

/retest-required

tnozicka commented 3 months ago

/override e2e-gke-release-script-latest

scylla-operator-bot[bot] commented 3 months ago

@tnozicka: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/scylladb/scylla-operator/pull/1861#issuecomment-2025170248): >/override e2e-gke-release-script-latest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tnozicka commented 3 months ago

/override ci/prow/e2e-gke-release-script-latest (shouldn't have been triggered here)

scylla-operator-bot[bot] commented 3 months ago

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to [this](https://github.com/scylladb/scylla-operator/pull/1861#issuecomment-2025171466): >/override ci/prow/e2e-gke-release-script-latest >(shouldn't have been triggered here) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.