search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Update Helm repo URL #1887

Closed charlychiu closed 2 months ago

charlychiu commented 2 months ago

Description of your changes:

Which issue is resolved by this Pull Request: Resolves #

scylla-operator-bot[bot] commented 2 months ago

Hi @charlychiu. Thanks for your PR.

I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yangkyeongmo commented 2 months ago

I had same issue caused by this, but just appending stable to existing url fixed the issue.

zimnx commented 2 months ago

Thanks, please amend PR and commit title in a way it would explain what is changed as a sentence. Check commit history for a style reference. /ok-to-test /kind documentation

charlychiu commented 2 months ago

@zimnx

Corrected, thx your reviewed

zimnx commented 2 months ago

/retest

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlychiu, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zimnx commented 2 months ago

CI is borked today, it will get merged once we fix it.

zimnx commented 2 months ago

/retest

rzetelskik commented 2 months ago

@charlychiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel-clusterip 533914a link unknown /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

known manager flake, unrelated /retest