search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Split Scylla Manager repair and backup task integration E2E tests #1891

Closed rzetelskik closed 2 months ago

rzetelskik commented 2 months ago

Description of your changes: This PR doesn't really bring any value in itself, but the test split allows for making the changes required for https://github.com/scylladb/scylla-operator/pull/1742 clearer, consequently making the review process easier.

Which issue is resolved by this Pull Request: Prerequisite for https://github.com/scylladb/scylla-operator/pull/1742

/kind feature /priority important-longterm /cc

scylla-operator-bot[bot] commented 2 months ago

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/1891): > > >**Description of your changes:** This PR doesn't really bring any value in itself, but the test split allows for making the changes required for https://github.com/scylladb/scylla-operator/pull/1742 clearer, consequently making the review process easier. > >**Which issue is resolved by this Pull Request:** >Prerequisite for https://github.com/scylladb/scylla-operator/pull/1742 > >/kind feature >/priority important-longterm >/cc > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel-clusterip 3787e95 link true /test e2e-gke-parallel-clusterip

https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1891/pull-scylla-operator-master-e2e-gke-parallel-clusterip/1779805444886237184#1:test-build-log.txt%3A948

Stuck on repair task deletion integration. Controller issued task deletion:

2024-04-15T10:03:39.679445365Z I0415 10:03:39.621523       1 manager/sync.go:134] "Executing action" action="delete task \"4bd2d3d8-419c-4355-acf5-423666addec9\""
...
2024-04-15T10:03:39.679523675Z I0415 10:03:39.641612       1 manager/controller.go:148] "Hit conflict, will retry in a bit" Key="e2e-test-scyllacluster-8gx9r-w6wn4/basic-2mzvl" Error="Operation cannot be fulfilled on scyllaclusters.scylla.scylladb.com \"basic-2mzvl\": the object has been modified; please apply your changes to the latest version and try again"

Manager doesn't have related logs. Wasn't propagated to status. Working on it as part of https://github.com/scylladb/scylla-operator/pull/1850.

https://github.com/scylladb/scylla-operator/issues/1694#issuecomment-2056545655

ci/prow/e2e-gke-parallel 3787e95 link true /test e2e-gke-parallel Full PR test history. Your PR dashboard.

Stuck on repair task deletion integration. Controller issued task deletion:

2024-04-15T10:03:20.346661594Z I0415 10:03:20.346612       1 manager/sync.go:134] "Executing action" action="delete task \"8c1bfa4c-e08c-41ab-b5ac-6dedd51b7ede\""
...
2024-04-15T10:03:20.434715683Z I0415 10:03:20.374406       1 manager/controller.go:148] "Hit conflict, will retry in a bit" Key="e2e-test-scyllacluster-2j6b9-r
gxkv/basic-qf87f" Error="Operation cannot be fulfilled on scyllaclusters.scylla.scylladb.com \"basic-qf87f\": the object has been modified; please apply your c
hanges to the latest version and try again"

Manager doesn't have related logs. Wasn't propagated to status. Working on it as part of https://github.com/scylladb/scylla-operator/pull/1850.

https://github.com/scylladb/scylla-operator/issues/1694#issuecomment-2056547274

/retest

rzetelskik commented 2 months ago

/cc zimnx tnozicka

rzetelskik commented 2 months ago

/test e2e-gke-parallel-clusterip cluster provisioning failed

rzetelskik commented 2 months ago

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel 3787e95 link true /test e2e-gke-parallel

ditto https://github.com/scylladb/scylla-operator/issues/1694#issuecomment-2056712305

ci/prow/e2e-gke-parallel-clusterip 3787e95 link true /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

ditto https://github.com/scylladb/scylla-operator/issues/1694#issuecomment-2056713623

/retest

tnozicka commented 2 months ago

/approve /assign @zimnx

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment