scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Update sphinx-scylladb-theme to 1.7.1 #1895

Closed rzetelskik closed 2 months ago

rzetelskik commented 2 months ago

Description of your changes: Update sphinx-scylladb-theme docs dependency to 1.7.1. Most notably, it adds https://github.com/scylladb/sphinx-scylladb-theme/pull/1051.

Which issue is resolved by this Pull Request: Resolves #1893

/kind machinery /priority important-soon

scylla-operator-bot[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

rzetelskik commented 2 months ago

/kind machinery /priority important-soon

tnozicka commented 2 months ago

hm, the menu is gone /hold

Screenshot from 2024-04-16 12-00-05

rzetelskik commented 2 months ago

@tnozicka works for me, including the auto scroll image

$ podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.5 bash -euExo pipefail -O inherit_errexit -c 'make setup dirhtml multiversionpreview'

tnozicka commented 2 months ago

I run poetry install && make preview inside the container. That used to work before, I can try this on a clean system if you confirm it works for you but there can be something hidden related to the upgrade.

tnozicka commented 2 months ago

make setup dirhtml multiversionpreview

btw. those are run in parallel / racy (modulo explicit deps order) depending on other things but the order is generally not guaranteed

rzetelskik commented 2 months ago

podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.5 bash -euExo pipefail -O inherit_errexit -c 'poetry install && make preview'

This also works fine for me.

image

Did you clean the build dir before running it?

tnozicka commented 2 months ago

never had to but it helped /shrug

/approve /lgtm

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rzetelskik commented 2 months ago

@tnozicka can we cancel the hold then?

tnozicka commented 2 months ago

/hold cancel