Closed rzetelskik closed 2 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/kind machinery /priority important-soon
hm, the menu is gone /hold
@tnozicka works for me, including the auto scroll
$ podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.5 bash -euExo pipefail -O inherit_errexit -c 'make setup dirhtml multiversionpreview'
I run poetry install && make preview
inside the container. That used to work before, I can try this on a clean system if you confirm it works for you but there can be something hidden related to the upgrade.
make setup dirhtml multiversionpreview
btw. those are run in parallel / racy (modulo explicit deps order) depending on other things but the order is generally not guaranteed
podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.5 bash -euExo pipefail -O inherit_errexit -c 'poetry install && make preview'
This also works fine for me.
Did you clean the build dir before running it?
never had to but it helped /shrug
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rzetelskik, tnozicka
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@tnozicka can we cancel the hold then?
/hold cancel
Description of your changes: Update sphinx-scylladb-theme docs dependency to 1.7.1. Most notably, it adds https://github.com/scylladb/sphinx-scylladb-theme/pull/1051.
Which issue is resolved by this Pull Request: Resolves #1893
/kind machinery /priority important-soon