search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
323 stars 159 forks source link

Modularize e2e scripts #1901

Closed tnozicka closed 1 month ago

tnozicka commented 2 months ago

Description of your changes: This PR splits the e2e scripts into reusable modules so we don't have to duplicate the logic in future variants, like #1837

It also fixes must-gather collection to be more modular removes the dependency on e2e namespace that may not exist yet. (I think it also addresses a few other corner cases that were failing on the split.)

tnozicka commented 1 month ago

/cc @rzetelskik

scylla-operator-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 1 month ago

manager flake /retest

rzetelskik commented 1 month ago

@tnozicka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel-clusterip a8c4698 link true /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

manager flake @tnozicka should we just override it? I'm waiting for it to rebase https://github.com/scylladb/scylla-operator/pull/1881.

tnozicka commented 1 month ago

not a fan of overrides, but this is touching only the scripts so we can make an exception if it fails again

tnozicka commented 1 month ago

/override ci/prow/e2e-gke-parallel-clusterip (scripts are not related to the manager flake)

scylla-operator-bot[bot] commented 1 month ago

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-parallel-clusterip

In response to [this](https://github.com/scylladb/scylla-operator/pull/1901#issuecomment-2112405595): >/override ci/prow/e2e-gke-parallel-clusterip >(scripts are not related to the manager flake) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.