search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
323 stars 159 forks source link

Update Local Volume Provisioner command to only reference the new file path for the xfs storageclass. #1906

Closed MatthewGow closed 2 months ago

MatthewGow commented 2 months ago

Description of your changes: Updating documentation found here: https://operator.docs.scylladb.com/stable/eks.html

This example was removed as part of: https://github.com/scylladb/scylla-operator/pull/1656

This second command can be excluded since the previous command would now pick it up as it was moved to: examples/common/local-volume-provisioner/local-csi-driver

Which issue is resolved by this Pull Request: Resolves #1905

scylla-operator-bot[bot] commented 2 months ago

Hi @MatthewGow. Thanks for your PR.

I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MatthewGow commented 2 months ago

Thanks for the review @rzetelskik ! That makes sense - I have amended my commit and title as suggested. :+1:

rzetelskik commented 2 months ago

Thanks @MatthewGow /lgtm /assign zimnx

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatthewGow, rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment