search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
332 stars 162 forks source link

Fix assertion in e2e testing ingress connectivity #1919

Closed zimnx closed 4 months ago

zimnx commented 4 months ago

Eventually block without .Should(o.Succeed()) silently passes after first failed execution. This adds this missing assertion fixing the test.

rzetelskik commented 4 months ago

Any chance this is related to https://github.com/scylladb/scylla-operator/issues/1476?

scylla-operator-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zimnx commented 4 months ago

Any chance this is related to https://github.com/scylladb/scylla-operator/issues/1476?

I don't think so, what I'm fixing in this PR are false positives.

zimnx commented 4 months ago

2x manager flake /retest

zimnx commented 4 months ago

And another one manager flake /retest

zimnx commented 4 months ago

come on manager /retest

zimnx commented 4 months ago

again /retest

zimnx commented 4 months ago

Manager flake

/override ci/prow/e2e-gke-parallel-clusterip

scylla-operator-bot[bot] commented 4 months ago

@zimnx: Overrode contexts on behalf of zimnx: ci/prow/e2e-gke-parallel-clusterip

In response to [this](https://github.com/scylladb/scylla-operator/pull/1919#issuecomment-2112005188): >Manager flake > >/override ci/prow/e2e-gke-parallel-clusterip Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.