search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
323 stars 159 forks source link

[WIP] Split startup logic out of ScyllaDB container #1934

Open tnozicka opened 1 month ago

tnozicka commented 1 month ago

Description of your changes: Startup logic should run in a separate container. See https://github.com/scylladb/scylla-operator/issues/1940 for more context.

This PR adds the scylla-operator run-ignition command, that runs in its' own container and signals ScyllaDB container by creating a file that unblocks its start up. Unfortunately, we can't do this with an init container because we need ScyllaDB container running so tuning can be run and its result can unblock the startup.

Which issue is resolved by this Pull Request: Resolves #1941

Requires

scylla-operator-bot[bot] commented 1 month ago

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/1934): >**Description of your changes:** >TODO > >**Which issue is resolved by this Pull Request:** >Resolves TODO > >### Requires >- [ ](#1926) > >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
scylla-operator-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
scylla-operator-bot[bot] commented 1 month ago

@tnozicka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit b96fc348e5a60f1fe7864bb0d68c2563e0318d81 link true /test unit
ci/prow/e2e-gke-serial b96fc348e5a60f1fe7864bb0d68c2563e0318d81 link true /test e2e-gke-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
scylla-operator-bot[bot] commented 3 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.