search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
323 stars 159 forks source link

Remove redundant check in ci deploy script #1945

Closed tnozicka closed 1 month ago

tnozicka commented 1 month ago

Description of your changes: When the object is created all the requests through any apiserver should be able to read it immediately. kubectl shouldn't hit watch cache.

Which issue is resolved by this Pull Request: Resolves https://github.com/scylladb/scylla-operator/pull/1837#discussion_r1616104566

/cc @rzetelskik

scylla-operator-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 1 month ago

/override ci/prow/e2e-gke-release-script-latest (not working yet)

scylla-operator-bot[bot] commented 1 month ago

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to [this](https://github.com/scylladb/scylla-operator/pull/1945#issuecomment-2135055346): >/override ci/prow/e2e-gke-release-script-latest >(not working yet) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.