search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
332 stars 162 forks source link

Add an E2E test suite for multi-datacenter clusters #1953

Closed rzetelskik closed 3 months ago

rzetelskik commented 3 months ago

Description of your changes: This PR introduces a multi-datacenter E2E test suite with a basic test verifying a multi-datacenter cluster can form across multiple Kubernetes clusters, using external seeds to connect datacenters.

Which issue is resolved by this Pull Request: Resolves

Requires:

/kind feature /priority important-longterm /cc

scylla-operator-bot[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

scylla-operator-bot[bot] commented 3 months ago

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/1953): > > >**Description of your changes:** This PR introduces a multi-datacenter E2E test suite with a basic test verifying a multi-datacenter cluster can form across multiple Kubernetes clusters, using external seeds to connect datacenters. > >**Which issue is resolved by this Pull Request:** >Resolves #1320 > >Requires: >- https://github.com/scylladb/scylla-operator/pull/1951 >- https://github.com/scylladb/scylla-operator/pull/1952 >- https://github.com/scylladb/scylla-operator-release/pull/81 > >/kind feature >/priority important-longterm >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rzetelskik commented 3 months ago

This will only be able to run once https://github.com/scylladb/scylla-operator-release/pull/81 is unblocked, but should be ready for review by itself. /cc zimnx /assign zimnx

rzetelskik commented 3 months ago

/retest cluster provisioning failed

rzetelskik commented 3 months ago

/hold for an optional presubmit with multi-datacenter infra

rzetelskik commented 3 months ago

/hold cancel @zimnx presubmit passed, ready for review

rzetelskik commented 3 months ago

/test e2e-gke-multi-datacenter-parallel

rzetelskik commented 3 months ago

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel-clusterip 946dc9a link true /test e2e-gke-parallel-clusterip Full PR test history. Your PR dashboard.

https://github.com/scylladb/scylla-operator/issues/1028#issuecomment-2186566211 unrelated /retest

rzetelskik commented 3 months ago

/test images e2e-gke-parallel-clusterip

scylla-operator-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rzetelskik commented 3 months ago

thanks for the updates, 2 nits /approve

Applied. Also aligned Cluster/Namespace/ScyllaCluster indexing, I forgot about it earlier.

tnozicka commented 3 months ago

thx, that one was truly optional

/lgtm

scylla-operator-bot[bot] commented 3 months ago

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-multi-datacenter-parallel ce7c5d7201a6520963f369d07e858a2be44d4406 link false /test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rzetelskik commented 3 months ago

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-multi-datacenter-parallel ce7c5d7 link false /test e2e-gke-multi-datacenter-parallel Full PR test history. Your PR dashboard.

Invalid value: "a ": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Didn't notice a whitespace there... Fixed, @tnozicka please tag again.

tnozicka commented 3 months ago

/lgtm