scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
322 stars 159 forks source link

Use broadcast_address for seeds in external seeds E2E #1984

Closed rzetelskik closed 1 week ago

rzetelskik commented 1 week ago

Description of your changes: This PR makes the e2e test covering manual multi-datacenter setup use broadcast_address for seeds. It also unifies the usage of framework interface in this test.

Which issue is resolved by this Pull Request: Resolves https://github.com/scylladb/scylla-operator/issues/1983

/kind feature /priority important-soon /cc

scylla-operator-bot[bot] commented 1 week ago

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/1984): > > >**Description of your changes:** >This PR makes the e2e test covering manual multi-datacenter setup use broadcast_address for seeds. It also unifies the usage of framework interface in this test. > >**Which issue is resolved by this Pull Request:** >Resolves https://github.com/scylladb/scylla-operator/issues/1983 > >/kind feature >/priority important-soon >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
scylla-operator-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment