scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
332 stars 162 forks source link

Fix flakiness of cleanup E2E test #1999

Closed zimnx closed 3 months ago

zimnx commented 3 months ago

Cleanup token hash annotation is reconciled from the sidecar via polling method. If ring annotation is updated slower than new node joins/decommisions then cleanup job can be triggered twice. This is expected, so e2e test shouldn't fail in such case.

Test logic was aligned to accept extra cleanup job for stale token ring hash, by filtering observed jobs to get only those related to current token ring.

Fixes #1525

scylla-operator-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment