search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
324 stars 159 forks source link

Fix NodeConfig controller handlers to react on related object updates #2000

Open tnozicka opened 2 days ago

tnozicka commented 2 days ago

Description of your changes: This PR fixes the handlers so the reconciled objects that don't have ownerRefs on them requeue the NodeConfigs. Given they are shared, they need to requeue all of them but the number of NodeConfigs is usually low single digit number anyway.

Which issue is resolved by this Pull Request: Resolves #2001

scylla-operator-bot[bot] commented 2 days ago

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/2000): >**Description of your changes:** > > >**Which issue is resolved by this Pull Request:** >Resolves # > >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tnozicka commented 1 day ago

/cc @rzetelskik @zimnx

scylla-operator-bot[bot] commented 1 day ago

@tnozicka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip e310a55a391c9d9f9a1aeae8dacb2f0d6a097aec link true /test e2e-gke-parallel-clusterip

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
scylla-operator-bot[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment