scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
332 stars 162 forks source link

Allow changing default loglevel for ScyllaDB #2011

Open tnozicka opened 2 months ago

tnozicka commented 2 months ago

As a user I'd like to change the default loglevel for all ScyllaDB components using --default-log-level flag in spec.scyllaArgs.

While we allow adding extra flags with spec.scyllaArgs, when configured with scyllaArgs: "--default-log-level=trace" the ScyllaDB startup scripts fail because they have hard wired the flag with info level and it can be defined only once

Scylla version 6.0.1-0.20240612.bc89aac9d017 with build-id e845b7c6530ae1385e7bb3b7def09b4ffdf191c2 starting ...
command used: "/usr/bin/scylla --log-to-syslog 0 --log-to-stdout 1 --default-log-level info --network-stack posix --developer-mode=1 --smp 1 --overprovisioned --listen-address 0.0.0.0 --rpc-address 0.0.0.0 --seed-provider-parameters seeds=10.85.5.102 --broadcast-address 10.85.5.102 --broadcast-rpc-address 10.85.5.102 --alternator-address 0.0.0.0 --blocked-reactor-notify-ms 999999999 --default-log-level=trace --prometheus-address=0.0.0.0"
pid: 58
parsed command line options: [log-to-syslog, (positional) 0, log-to-stdout, (positional) 1, default-log-level, (positional) info, network-stack, (positional) posix, developer-mode: 1, smp, (positional) 1, overprovisioned, listen-address: 0.0.0.0, rpc-address: 0.0.0.0, seed-provider-parameters: seeds=10.85.5.102, broadcast-address: 10.85.5.102, broadcast-rpc-address: 10.85.5.102, alternator-address: 0.0.0.0, blocked-reactor-notify-ms, (positional) 999999999, default-log-level: trace, prometheus-address: 0.0.0.0]
error: option '--default-log-level' cannot be specified more than once

Try --help.
tnozicka commented 2 months ago

blocked by https://github.com/scylladb/scylladb/issues/19660