search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
339 stars 175 forks source link

Fix NodeConfig e2e race check with node setup daemon #2101

Closed tnozicka closed 2 months ago

tnozicka commented 2 months ago

Description of your changes: This PR fixes a race where NodeConfig e2es weren't waiting for all daemons to update NodeConfig status before calling verifyNodeConfig which failed on conditions check.

scylla-operator-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 2 months ago

https://github.com/scylladb/scylla-operator/issues/1028#issuecomment-2316968094 /retest