scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
339 stars 175 forks source link

Extend node tune controller with status conditions #2165

Closed rzetelskik closed 1 week ago

rzetelskik commented 3 weeks ago

Description of your changes: Node tune controller does not currently set status conditions on NodeConfig's reconciliation. Instead it only set status' NodeStatuses. While this is enough for checking the status programmatically, setting and aggregating status conditions allows for a better UX, by giving the users an option to query NodeConfig conditions. This PR extends the node tune controller with per-node status conditions and further aggregates them with the existing ones in NodeConfig controller.

It also adds handlers for NodeConfig events to node tune controller and aligns the existing e2e tests with the changes.

Which issue is resolved by this Pull Request: Resolves #1920

/kind feature /priority important-longterm /cc

scylla-operator-bot[bot] commented 3 weeks ago

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/2165): > > >**Description of your changes:** wip > >**Which issue is resolved by this Pull Request:** >Resolves #1920 > >/kind feature >/priority important-longterm >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rzetelskik commented 3 weeks ago

/cc zimnx tnozicka

rzetelskik commented 2 weeks ago

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel a0714b1 link true /test e2e-gke-parallel Full PR test history. Your PR dashboard.

New flake https://github.com/scylladb/scylla-operator/issues/2185, unrelated to these changes though.

rzetelskik commented 2 weeks ago

/retest

tnozicka commented 1 week ago

/approve /lgtm

scylla-operator-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment