Closed rzetelskik closed 1 week ago
@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.
Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.
/cc zimnx tnozicka
@rzetelskik: The following test failed, say
/retest
to rerun all failed tests or/retest-required
to rerun all mandatory failed tests:Test name Commit Details Required Rerun command ci/prow/e2e-gke-parallel a0714b1 link true
/test e2e-gke-parallel
Full PR test history. Your PR dashboard.
New flake https://github.com/scylladb/scylla-operator/issues/2185, unrelated to these changes though.
/retest
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rzetelskik, tnozicka, zimnx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description of your changes: Node tune controller does not currently set status conditions on NodeConfig's reconciliation. Instead it only set status' NodeStatuses. While this is enough for checking the status programmatically, setting and aggregating status conditions allows for a better UX, by giving the users an option to query NodeConfig conditions. This PR extends the node tune controller with per-node status conditions and further aggregates them with the existing ones in NodeConfig controller.
It also adds handlers for NodeConfig events to node tune controller and aligns the existing e2e tests with the changes.
Which issue is resolved by this Pull Request: Resolves #1920
/kind feature /priority important-longterm /cc