search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
339 stars 175 forks source link

Do not set ScyllaCluster's ManagerID to empty string when calculating status #2177

Closed rzetelskik closed 2 weeks ago

rzetelskik commented 2 weeks ago

Description of your changes: Manager integration e2es have been flaking on manager's ClusterID missing on manual schema restore task registration. This is due to a change introduced in #2156 which was causing the field in status to be intermittently set to an empty string. This, together with not bulletproof enough assertions in our e2es, caused the tests to try and register the tasks too early, before the cluster was even registered with manager. This PR fixes it by setting the status manager ID field to nil instead of an empty string, fixing the e2e assertions and adding dedicated sanity checks before scheduling the restore tasks.

Which issue is resolved by this Pull Request: Resolves #2161

/kind flake /priority important-soon /cc

scylla-operator-bot[bot] commented 2 weeks ago

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/scylladb/scylla-operator/pull/2177): > > >**Description of your changes:** Manager integration e2es have been flaking on manager's ClusterID missing on manual schema restore task registration. This is due to a change introduced in #2156 which was causing the field in status to be intermittently set to an empty string. This, together with not bulletproof enough assertions in our e2es, caused the tests to try and register the tasks too early, before the cluster was even registered with manager. >This PR fixes it by setting the status manager ID field to nil instead of an empty string, fixing the e2e assertions and adding dedicated sanity checks before scheduling the restore tasks. > >**Which issue is resolved by this Pull Request:** >Resolves #2161 > >/kind flake >/priority important-soon >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
scylla-operator-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment