search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
339 stars 175 forks source link

Add an E2E test for NodeConfig mount degraded condition propagation for mounts over corrupted xfs filesystems #2178

Closed rzetelskik closed 2 weeks ago

rzetelskik commented 2 weeks ago

Description of your changes: This PR adds an e2e test verifying that NodeConfig ends up with a degraded status condition when trying to mount over a corrupted xfs filesystem. The behaviour itself, as requested by #1158, was already there since merging #2134.

Which issue is resolved by this Pull Request: Resolves #1558

/priority important-longterm

rzetelskik commented 2 weeks ago

@zimnx @tnozicka ptal

rzetelskik commented 2 weeks ago

I think this could be done simpler by creating a broken XFS initially using a pod in the preNodeConfigCreationFunc and reusing more of the existing code (avoids the extra rollout wait and patch) but I don't feel strong

Depends on what you consider simpler - I started by trying to do it this way but at some point I realised the client pod started to turn into the nodeconfig controller because it had to perform the exact same steps to set it up. I think this way is clearer in terms of highlighting the broken setup. In terms of the test entry complexity it's admittedly worse - perhaps the test table could use a rehaul.

scylla-operator-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/scylla-operator/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment