search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
323 stars 159 forks source link

examples/gke/cpu-policy-daemonset.yaml removed from folder but still in documentation #527

Open danias opened 3 years ago

danias commented 3 years ago

Hi @zimnx ,

I am a Scylla noob and I saw that you removed examples/gke/cpu-policy-daemonset.yaml a few days ago. Nonetheless, the GKE instructions have not been updated accordingly. Is this still required as a step? If not, it would have been useful to include in the comments why it has been removed or maybe to remove the CPU policy section from the instructions.

Thanks! Vasilis

danias commented 3 years ago

I saw that systemconfig.yaml was added which is referenced by gke.sh and in general gke.sh seems to have updated information (e.g. no gcloud beta etc.) which means that the documentation is outdated. I will test the steps and submit a PR with the updated documentation if I manage.

zimnx commented 3 years ago

Thanks for noticing, contributions are welcomed. master documentation may be not always synced with the code. I would suggest to use latest release branch and documentation.