search

scylladb / scylla-operator

The Kubernetes Operator for ScyllaDB
https://operator.docs.scylladb.com/
Apache License 2.0
339 stars 175 forks source link

Always resolve SCYLLA_OPERATOR_IMAGE to sha reference #680

Open tnozicka opened 3 years ago

tnozicka commented 3 years ago

Is this a bug report or feature request?

What should the feature do: If someone useses a rolling update tag like latest or 1.3 for SCYLLA_OPERATOR_IMAGE, we won't initiate a rolling restart to update the sidecar image. We should always use sha in the objects we generate even if the user forgot to do so.

rzetelskik commented 3 years ago

@tnozicka why would we want to initiate a rolling restart whenever a new image is published using an existing tag? I've consulted this behaviour with @zimnx and he expressed concern as well.

tnozicka commented 3 years ago

the operator image is embedded in every scylla deployment for the side car so if the user:

  1. deploys the operator with latest, currently pointing to 1.4.0
  2. deploys a ScyllaCluster with 3 replicas, sidecar get's the image for 1.4.0
  3. :latest changes to 1.5.0
  4. :latest changes to 1.6.0
  5. now you have an unsupported skew because the image is effectively not reconciled
  6. one of the scylla pods gets evicted and the new pod resolves to 1.6.0 while the other two still run from 1.4.0

similar issues arise for the case when a tag is rewritten, sha is the only way to reliably reference the same image

scylla-operator-bot[bot] commented 4 months ago

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

/lifecycle stale

tnozicka commented 4 months ago

This may be be replaced by splitting this logic into a separate image but until we have a plan for that let's keep this here. /remove-lifecycle stale

scylla-operator-bot[bot] commented 3 months ago

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

/lifecycle stale

tnozicka commented 3 months ago

/remove-lifecycle stale

scylla-operator-bot[bot] commented 2 months ago

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

/lifecycle stale

tnozicka commented 2 months ago

/remove-lifecycle stale

scylla-operator-bot[bot] commented 1 month ago

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

/lifecycle stale

scylla-operator-bot[bot] commented 2 weeks ago

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

/lifecycle rotten

tnozicka commented 2 weeks ago

/remove-lifecycle rotten /triage accepted