scylladb / scylla-rust-driver

Async CQL driver for Rust, optimized for ScyllaDB!
Apache License 2.0
571 stars 99 forks source link

semver_checks: Revert previous workaround #1051

Closed Lorak-mmk closed 2 months ago

Lorak-mmk commented 2 months ago

The change in semver-checks turned out to be intentional and cargo install cargo-semver-checks --no-default-features is no longer expected to work. The replacement command is cargo install cargo-semver-checks --no-default-features --features gix-reqwest.

See the release notes for v0.33.0: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.33.0

Pre-review checklist

github-actions[bot] commented 2 months ago

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳 Checked commit: e79becfbf79f6b83e84c1e30f81870680cbf1b9a

wprzytula commented 2 months ago

Are you going to open a PR to this branch in order to check that the Semver Checks are indeed working after the changes?

Lorak-mmk commented 2 months ago

Yes: https://github.com/Lorak-mmk/scylla-rust-driver/pull/2 it passes, apart from removing label because those labels are not present on my fork.

Lorak-mmk commented 2 months ago

Done @wprzytula