search

scylladb / scylla-tools-java

Apache Cassandra, supplying tools for Scylla
Apache License 2.0
53 stars 85 forks source link

Update Java Driver version to 3.11.2.4 #321

Closed avelanarius closed 1 year ago

avelanarius commented 1 year ago

Update the version of Java Driver from 3.11.2.1 to 3.11.2.4. The differences between the versions are fixes to serverless support:

  1. Driver connecting to address in "Server" field of the bundle instead of "NodeDomain" (https://github.com/scylladb/java-driver/pull/173)
  2. Moving parsing of "insecureSkipTlsVerify" from "AuthInfo" field in serverless bundle file to "Datacenter" fields (https://github.com/scylladb/java-driver/pull/177)

Without this change, cassandra-stress could not connect correctly to a local serverless cluster created with Scylla Operator or CCM (see https://github.com/scylladb/java-driver/issues/164).

Tested manually end-to-end scenario: starting serverless Scylla with CCM and using cassandra-stress to write to it:

mkdir /tmp/ccm-with-tools-java
ccm create ccm_with_tools_java -i 127.0.1. -n 1 --scylla -v release:5.0.0 --config-dir=/tmp/ccm-with-tools-java
ccm start  --sni-proxy --sni-port 7777 --config-dir=/tmp/ccm-with-tools-java
./tools/bin/cassandra-stress write -cloudconf "file=/tmp/ccm-with-tools-java/ccm_with_tools_java/config_data.yaml"
avelanarius commented 1 year ago

Scylla CI with this branch of scylla-tools-java passed successfully: https://github.com/scylladb/scylladb/pull/12094

avelanarius commented 1 year ago

(Changing to draft for a second, will bump it to 3.11.2.4 which will have https://github.com/scylladb/java-driver/commit/22e3ad5dc0de4cea8fe45370ff6fa4650c4bafd1)

avelanarius commented 1 year ago

v2: Update to 3.11.2.4 (v1 of PR was update to 3.11.2.3)

Ran CI tests again and they passed correctly: https://github.com/scylladb/scylladb/pull/12094

ping @avikivity for review and merge

fruch commented 1 year ago

@nyh is there a github group of the core maintainers that we can ping ? inside of picking up on specific ones that might be busy, i.e. like @avikivity ?

nyh commented 1 year ago

I don't know, but I'll take it as a hint and review this patch myself :-)

fruch commented 1 year ago

I don't know, but I'll take it as a hint and review this patch myself :-)

Thanks @nyh, I was waiting for the fixes in this for a couple of weeks.

nyh commented 1 year ago

Yes, our review process is famous for its speed ;-)

avikivity commented 1 year ago

@nyh is there a github group of the core maintainers that we can ping ? inside of picking up on specific ones that might be busy, i.e. like @avikivity ?

@scylladb/scylla-maint